Code Review for cpu-pause-func-v1

Prepared by:Jeff (jeffpc) on 2014-Apr-12 18:21 -0400 EDT
Workspace:/home/jeffpc/illumos/cpu-pause-func (at 3909619d8dcc)
Compare against: HEAD^ (at 0b5ce10aee80)
Summary of changes: 73 lines changed: 3 ins; 20 del; 50 mod; 38535 unchg
Patch of changes: cpu-pause-func-v1.patch
Printable review: cpu-pause-func-v1.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/cpr/cpr_main.c 

XXXX pass in cpu_pause_func via pause_cpus
17 lines changed: 0 ins; 15 del; 2 mod; 1377 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/disp/cmt.c 

XXXX pass in cpu_pause_func via pause_cpus
3 lines changed: 0 ins; 0 del; 3 mod; 1962 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/disp/cpupart.c 

XXXX pass in cpu_pause_func via pause_cpus
3 lines changed: 0 ins; 0 del; 3 mod; 1228 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/disp/disp.c 

XXXX pass in cpu_pause_func via pause_cpus
1 line changed: 0 ins; 0 del; 1 mod; 2700 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/cpu.c 

XXXX pass in cpu_pause_func via pause_cpus
19 lines changed: 3 ins; 2 del; 14 mod; 3434 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/cpu_event.c 

XXXX pass in cpu_pause_func via pause_cpus
2 lines changed: 0 ins; 0 del; 2 mod; 1154 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/cpu_pm.c 

XXXX pass in cpu_pause_func via pause_cpus
2 lines changed: 0 ins; 0 del; 2 mod; 789 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/lgrp.c 

XXXX pass in cpu_pause_func via pause_cpus
3 lines changed: 0 ins; 0 del; 3 mod; 4438 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/lgrp_topo.c 

XXXX pass in cpu_pause_func via pause_cpus
1 line changed: 0 ins; 0 del; 1 mod; 1591 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/mem_config.c 

XXXX pass in cpu_pause_func via pause_cpus
1 line changed: 0 ins; 0 del; 1 mod; 3316 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/cpuvar.h 

XXXX pass in cpu_pause_func via pause_cpus
1 line changed: 0 ins; 0 del; 1 mod; 838 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/i86hvm/io/xpv/xpv_support.c 

XXXX pass in cpu_pause_func via pause_cpus
1 line changed: 0 ins; 0 del; 1 mod; 815 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/io/dr/dr_quiesce.c 

XXXX pass in cpu_pause_func via pause_cpus
1 line changed: 0 ins; 0 del; 1 mod; 1044 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/io/ppm/acpisleep.c 

XXXX pass in cpu_pause_func via pause_cpus
2 lines changed: 0 ins; 2 del; 0 mod; 185 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/os/cpr_impl.c 

XXXX pass in cpu_pause_func via pause_cpus
1 line changed: 0 ins; 0 del; 1 mod; 1137 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/os/machdep.c 

XXXX pass in cpu_pause_func via pause_cpus
1 line changed: 0 ins; 0 del; 1 mod; 1441 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/os/mp_pc.c 

XXXX pass in cpu_pause_func via pause_cpus
1 line changed: 0 ins; 1 del; 0 mod; 659 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/os/x_call.c 

XXXX pass in cpu_pause_func via pause_cpus
1 line changed: 0 ins; 0 del; 1 mod; 705 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86xpv/os/mp_xen.c 

XXXX pass in cpu_pause_func via pause_cpus
1 line changed: 0 ins; 0 del; 1 mod; 1058 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4/os/mp_states.c 

XXXX pass in cpu_pause_func via pause_cpus
1 line changed: 0 ins; 0 del; 1 mod; 331 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4/os/prom_subr.c 

XXXX pass in cpu_pause_func via pause_cpus
2 lines changed: 0 ins; 0 del; 2 mod; 589 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/io/mem_cache.c 

XXXX pass in cpu_pause_func via pause_cpus
1 line changed: 0 ins; 0 del; 1 mod; 968 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/ngdr/io/dr_quiesce.c 

XXXX pass in cpu_pause_func via pause_cpus
1 line changed: 0 ins; 0 del; 1 mod; 1106 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/os/cpr_impl.c 

XXXX pass in cpu_pause_func via pause_cpus
1 line changed: 0 ins; 0 del; 1 mod; 2028 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/serengeti/io/sbdp_quiesce.c 

XXXX pass in cpu_pause_func via pause_cpus
1 line changed: 0 ins; 0 del; 1 mod; 888 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4v/os/mpo.c 

XXXX pass in cpu_pause_func via pause_cpus
1 line changed: 0 ins; 0 del; 1 mod; 2039 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4v/os/suspend.c 

XXXX pass in cpu_pause_func via pause_cpus
3 lines changed: 0 ins; 0 del; 3 mod; 715 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.