Print this page
patch tsoome-feedback
6659 nvlist_free(NULL) is a no-op

@@ -1010,11 +1010,10 @@
 pmr_done:
         if (meth_name)
                 xmlFree(meth_name);
         if (prop_name)
                 xmlFree(prop_name);
-        if (arg_nvl)
                 nvlist_free(arg_nvl);
         return (ret);
 }
 
 

@@ -1100,11 +1099,10 @@
         if (pcnt > 0) {
                 e |= (ai != pcnt);
                 e |= nvlist_add_nvlist_array(pgnvl, INV_PGRP_ALLPROPS, apl,
                     pcnt);
                 for (ai = 0; ai < pcnt; ai++)
-                        if (apl[ai] != NULL)
                                 nvlist_free(apl[ai]);
                 topo_mod_free(mp, apl, pcnt * sizeof (nvlist_t *));
                 if (e != 0) {
                         nvlist_free(pgnvl);
                         return (-1);