Print this page
6659 nvlist_free(NULL) is a no-op

Split Close
Expand all
Collapse all
          --- old/usr/src/cmd/fm/modules/common/syslog-msgs/syslog.c
          +++ new/usr/src/cmd/fm/modules/common/syslog-msgs/syslog.c
↓ open down ↓ 173 lines elided ↑ open up ↑
 174  174                  syslog_stats.msg_err.fmds_value.ui64++;
 175  175          }
 176  176  }
 177  177  
 178  178  static void
 179  179  free_notify_prefs(fmd_hdl_t *hdl, nvlist_t **prefs, uint_t nprefs)
 180  180  {
 181  181          int i;
 182  182  
 183  183          for (i = 0; i < nprefs; i++) {
 184      -                if (prefs[i])
 185      -                        nvlist_free(prefs[i]);
      184 +                nvlist_free(prefs[i]);
 186  185          }
 187  186  
 188  187          fmd_hdl_free(hdl, prefs, sizeof (nvlist_t *) * nprefs);
 189  188  }
 190  189  
 191  190  static int
 192  191  get_notify_prefs(fmd_hdl_t *hdl, nvlist_t *ev_nvl, nvlist_t ***pref_nvl,
 193  192      uint_t *nprefs)
 194  193  {
 195  194          nvlist_t *top_nvl, **np_nvlarr, *mech_nvl;
↓ open down ↓ 229 lines elided ↑ open up ↑
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX