Code Review for XXXX-nvlist_free-NULL-is-a-no-op

Prepared by: (jeffpc) on 2016-Feb-15 12:56 -0500 EST
Workspace:/home/jeffpc/illumos/nvlist-free (at 99210a729e38)
Compare against: master (at a7317ceb8141)
Summary of changes: 497 lines changed: 2 ins; 256 del; 239 mod; 235958 unchg
Patch of changes: XXXX-nvlist_free-NULL-is-a-no-op.patch
Printable review: XXXX-nvlist_free-NULL-is-a-no-op.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/beadm/beadm.c

patch tsoome-feedback
2 lines changed: 0 ins; 1 del; 1 mod; 1574 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/boot/bootadm/bootadm.c

6659 nvlist_free(NULL) is a no-op
4 lines changed: 0 ins; 2 del; 2 mod; 9981 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/sbin/dhcpagent/defaults.c

patch tsoome-feedback
2 lines changed: 0 ins; 1 del; 1 mod; 286 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.lib/vrrpd/vrrpd.c

patch tsoome-feedback
2 lines changed: 0 ins; 1 del; 1 mod; 4552 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.sbin/ipqosconf/ipqosconf.c

patch tsoome-feedback
patch cleanup
6659 nvlist_free(NULL) is a no-op
12 lines changed: 0 ins; 7 del; 5 mod; 10029 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dcs/sparc/sun4u/ri_init.c

patch tsoome-feedback
4 lines changed: 0 ins; 2 del; 2 mod; 2075 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dcs/sparc/sun4u/rsrc_info.c

patch tsoome-feedback
30 lines changed: 0 ins; 16 del; 14 mod; 1048 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/devfsadm/devfsadm.c

patch tsoome-feedback
6659 nvlist_free(NULL) is a no-op
4 lines changed: 0 ins; 2 del; 2 mod; 8736 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/fmd/common/fmd_case.c

6659 nvlist_free(NULL) is a no-op
4 lines changed: 0 ins; 2 del; 2 mod; 2520 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/fmd/common/fmd_event.c

patch tsoome-feedback
4 lines changed: 0 ins; 3 del; 1 mod; 363 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/fmd/common/fmd_xprt.c

6659 nvlist_free(NULL) is a no-op
10 lines changed: 0 ins; 5 del; 5 mod; 2012 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/fminject/common/inj_defn.c

patch tsoome-feedback
4 lines changed: 0 ins; 3 del; 1 mod; 833 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/fmtopo/common/fmtopo.c

patch tsoome-feedback
2 lines changed: 0 ins; 1 del; 1 mod; 1308 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/modules/common/disk-monitor/diskmon_conf.c

patch cleanup
6659 nvlist_free(NULL) is a no-op
6 lines changed: 0 ins; 4 del; 2 mod; 868 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/modules/common/disk-monitor/topo_gather.c

6659 nvlist_free(NULL) is a no-op
4 lines changed: 0 ins; 2 del; 2 mod; 790 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/modules/common/eversholt/fme.c

patch tsoome-feedback
6659 nvlist_free(NULL) is a no-op
15 lines changed: 0 ins; 7 del; 8 mod; 4294 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/modules/common/eversholt/itree.c

patch tsoome-feedback
4 lines changed: 0 ins; 2 del; 2 mod; 2168 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/modules/common/ext-event-transport/fmevt_inbound.c

patch tsoome-feedback
6659 nvlist_free(NULL) is a no-op
8 lines changed: 0 ins; 4 del; 4 mod; 650 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/modules/common/ip-transport/ip.c

patch tsoome-feedback
2 lines changed: 0 ins; 1 del; 1 mod; 1066 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/modules/common/sw-diag-response/subsidiary/panic/panic_diag.c

6659 nvlist_free(NULL) is a no-op
2 lines changed: 0 ins; 1 del; 1 mod; 589 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/modules/common/syslog-msgs/syslog.c

6659 nvlist_free(NULL) is a no-op
2 lines changed: 0 ins; 1 del; 1 mod; 422 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/modules/sun4/cpumem-diagnosis/cmd_dimm.c

patch tsoome-feedback
2 lines changed: 0 ins; 1 del; 1 mod; 530 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/modules/sun4/cpumem-diagnosis/cmd_pageerr.c

patch tsoome-feedback
2 lines changed: 0 ins; 1 del; 1 mod; 99 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/modules/sun4u/cpumem-diagnosis/cmd_oplerr.c

patch tsoome-feedback
6 lines changed: 0 ins; 4 del; 2 mod; 527 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/modules/sun4v/cpumem-diagnosis/cmd_hc_sun4v.c

patch tsoome-feedback
14 lines changed: 0 ins; 7 del; 7 mod; 639 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/modules/sun4v/cpumem-diagnosis/cmd_memerr_arch.c

6659 nvlist_free(NULL) is a no-op
2 lines changed: 0 ins; 1 del; 1 mod; 767 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/modules/sun4v/cpumem-retire/cma_cpu_sun4v.c

patch tsoome-feedback
2 lines changed: 0 ins; 1 del; 1 mod; 323 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/modules/sun4v/generic-mem/gmem_dimm.c

patch tsoome-feedback
2 lines changed: 0 ins; 1 del; 1 mod; 554 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/modules/sun4v/generic-mem/gmem_memerr.c

patch tsoome-feedback
12 lines changed: 0 ins; 6 del; 6 mod; 906 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/modules/sun4v/generic-mem/gmem_page.c

patch tsoome-feedback
6 lines changed: 0 ins; 3 del; 3 mod; 358 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/schemes/hc/scheme.c

patch tsoome-feedback
4 lines changed: 0 ins; 2 del; 2 mod; 297 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/schemes/mem/mem.c

6659 nvlist_free(NULL) is a no-op
2 lines changed: 0 ins; 1 del; 1 mod; 565 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fs.d/nfs/mountd/mountd.c

patch tsoome-feedback
4 lines changed: 0 ins; 2 del; 2 mod; 3238 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/hotplugd/hotplugd_door.c

patch tsoome-feedback
4 lines changed: 0 ins; 2 del; 2 mod; 756 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mv/mv.c

patch tsoome-feedback
4 lines changed: 0 ins; 2 del; 2 mod; 2253 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/pcidr/pcidr.c

patch tsoome-feedback
4 lines changed: 0 ins; 3 del; 1 mod; 652 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/picl/plugins/common/devtree/picldevtree.c

6659 nvlist_free(NULL) is a no-op
2 lines changed: 0 ins; 1 del; 1 mod; 3789 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/picl/plugins/sun4v/piclsbl/piclsbl.c

patch tsoome-feedback
2 lines changed: 0 ins; 1 del; 1 mod; 423 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/rcm_daemon/common/aggr_rcm.c

patch tsoome-feedback
2 lines changed: 0 ins; 1 del; 1 mod; 1468 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/rcm_daemon/common/ibpart_rcm.c

patch tsoome-feedback
2 lines changed: 0 ins; 1 del; 1 mod; 1366 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/rcm_daemon/common/vlan_rcm.c

patch tsoome-feedback
2 lines changed: 0 ins; 1 del; 1 mod; 1331 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/rcm_daemon/common/vnic_rcm.c

patch tsoome-feedback
2 lines changed: 0 ins; 1 del; 1 mod; 1342 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/syseventd/modules/sysevent_conf_mod/sysevent_conf_mod.c

6659 nvlist_free(NULL) is a no-op
4 lines changed: 0 ins; 2 del; 2 mod; 2278 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/zfs/zfs_main.c

patch tsoome-feedback
2 lines changed: 0 ins; 1 del; 1 mod; 7008 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/zoneadm/zfs.c

patch tsoome-feedback
4 lines changed: 0 ins; 2 del; 2 mod; 1676 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/zoneadmd/vplat.c

patch tsoome-feedback
2 lines changed: 0 ins; 1 del; 1 mod; 5323 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/zpool/zpool_main.c

6659 nvlist_free(NULL) is a no-op
4 lines changed: 0 ins; 2 del; 2 mod; 5316 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/zpool/zpool_vdev.c

patch tsoome-feedback
2 lines changed: 0 ins; 1 del; 1 mod; 1471 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/fsreparse/fs_reparse.c

6659 nvlist_free(NULL) is a no-op
2 lines changed: 0 ins; 1 del; 1 mod; 326 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/nvpair/nvpair.c

patch tsoome-feedback
2 lines changed: 0 ins; 1 del; 1 mod; 3298 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/cfgadm_plugins/ib/common/cfga_ib.c

6659 nvlist_free(NULL) is a no-op
2 lines changed: 0 ins; 1 del; 1 mod; 2126 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/cfgadm_plugins/sbd/common/ap_rcm.c

6659 nvlist_free(NULL) is a no-op
2 lines changed: 0 ins; 1 del; 1 mod; 1451 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/fm/libfmd_agent/common/fmd_agent.c

patch tsoome-feedback
4 lines changed: 0 ins; 2 del; 2 mod; 335 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/fm/libfmd_agent/i386/fmd_agent_i386.c

patch tsoome-feedback
4 lines changed: 0 ins; 2 del; 2 mod; 173 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/fm/libfmevent/common/fmev_publish.c

6659 nvlist_free(NULL) is a no-op
3 lines changed: 0 ins; 1 del; 2 mod; 533 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/fm/topo/libtopo/common/hc.c

patch tsoome-feedback
4 lines changed: 0 ins; 2 del; 2 mod; 2296 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/fm/topo/libtopo/common/sw.c

6659 nvlist_free(NULL) is a no-op
10 lines changed: 0 ins; 6 del; 4 mod; 520 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/fm/topo/libtopo/common/topo_fmri.c

patch tsoome-feedback
6 lines changed: 0 ins; 3 del; 3 mod; 1056 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/fm/topo/libtopo/common/topo_parse.c

patch tsoome-feedback
4 lines changed: 0 ins; 3 del; 1 mod; 212 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/fm/topo/libtopo/common/topo_prop.c

patch tsoome-feedback
14 lines changed: 0 ins; 7 del; 7 mod; 1533 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/fm/topo/libtopo/common/topo_xml.c

patch tsoome-feedback
6659 nvlist_free(NULL) is a no-op
4 lines changed: 0 ins; 2 del; 2 mod; 2133 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/fm/topo/modules/SUNW,SPARC-Enterprise/ioboard/opl_hostbridge.c

patch tsoome-feedback
2 lines changed: 0 ins; 1 del; 1 mod; 331 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/fm/topo/modules/common/disk/disk_common.c

6659 nvlist_free(NULL) is a no-op
4 lines changed: 0 ins; 1 del; 3 mod; 1012 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/fm/topo/modules/common/pcibus/did_props.c

patch tsoome-feedback
2 lines changed: 0 ins; 1 del; 1 mod; 947 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/fm/topo/modules/i86pc/chip/chip_amd.c

6659 nvlist_free(NULL) is a no-op
2 lines changed: 0 ins; 1 del; 1 mod; 848 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/fm/topo/modules/sun4v/cpuboard/cpuboard_hostbridge.c

patch tsoome-feedback
2 lines changed: 0 ins; 1 del; 1 mod; 299 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libbe/common/be_create.c

patch tsoome-feedback
16 lines changed: 0 ins; 8 del; 8 mod; 3082 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libbe/common/be_snapshot.c

patch tsoome-feedback
2 lines changed: 0 ins; 1 del; 1 mod; 810 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libcmdutils/common/process_xattrs.c

patch tsoome-feedback
6 lines changed: 0 ins; 3 del; 3 mod; 319 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libcontract/common/libcontract.c

patch cleanup
6659 nvlist_free(NULL) is a no-op
6 lines changed: 0 ins; 4 del; 2 mod; 556 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdiskmgt/common/entry.c

patch tsoome-feedback
6659 nvlist_free(NULL) is a no-op
6 lines changed: 0 ins; 3 del; 3 mod; 1302 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdladm/common/libdllink.c

patch tsoome-feedback
2 lines changed: 0 ins; 1 del; 1 mod; 1024 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libipp/libipp.c

patch tsoome-feedback
12 lines changed: 0 ins; 7 del; 5 mod; 905 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libnwam/common/libnwam_values.c

patch tsoome-feedback
2 lines changed: 0 ins; 1 del; 1 mod; 1141 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libpool/common/pool_kernel.c

6659 nvlist_free(NULL) is a no-op
4 lines changed: 0 ins; 2 del; 2 mod; 3587 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/librcm/librcm.c

patch cleanup
6659 nvlist_free(NULL) is a no-op
8 lines changed: 0 ins; 5 del; 3 mod; 1543 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libscf/common/notify_params.c

6659 nvlist_free(NULL) is a no-op
2 lines changed: 0 ins; 1 del; 1 mod; 1977 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libsysevent/libsysevent.c

6659 nvlist_free(NULL) is a no-op
4 lines changed: 0 ins; 2 del; 2 mod; 2664 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libzfs/common/libzfs_config.c

patch tsoome-feedback
2 lines changed: 0 ins; 1 del; 1 mod; 453 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libzfs/common/libzfs_dataset.c

6659 nvlist_free(NULL) is a no-op
4 lines changed: 0 ins; 2 del; 2 mod; 4751 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libzfs/common/libzfs_import.c

6659 nvlist_free(NULL) is a no-op
2 lines changed: 0 ins; 1 del; 1 mod; 1698 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libzfs/common/libzfs_pool.c

6659 nvlist_free(NULL) is a no-op
14 lines changed: 0 ins; 7 del; 7 mod; 4029 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libzfs/common/libzfs_sendrecv.c

6659 nvlist_free(NULL) is a no-op
2 lines changed: 0 ins; 1 del; 1 mod; 3635 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/pylibbe/common/libbe_py.c

patch tsoome-feedback
1 line changed: 0 ins; 0 del; 1 mod; 1099 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3nvpair/nvlist_alloc.3nvpair
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

patch more-manpage
patch cleanup
3 lines changed: 1 ins; 0 del; 2 mod; 595 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man9f/nvlist_alloc.9f
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

patch more-manpage
patch cleanup
3 lines changed: 1 ins; 0 del; 2 mod; 650 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/avs/ns/nsctl/nsc_trap.c

6659 nvlist_free(NULL) is a no-op
2 lines changed: 0 ins; 1 del; 1 mod; 80 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/contract/device.c

6659 nvlist_free(NULL) is a no-op
2 lines changed: 0 ins; 1 del; 1 mod; 2217 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/dev/sdev_ncache.c

6659 nvlist_free(NULL) is a no-op
2 lines changed: 0 ins; 1 del; 1 mod; 911 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/dev/sdev_subr.c

6659 nvlist_free(NULL) is a no-op
10 lines changed: 0 ins; 5 del; 5 mod; 3138 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/nfs/nfs4_state.c

6659 nvlist_free(NULL) is a no-op
6 lines changed: 0 ins; 3 del; 3 mod; 4008 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/smbsrv/smb_kshare.c

patch tsoome-feedback
4 lines changed: 0 ins; 2 del; 2 mod; 1227 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/spa.c

6659 nvlist_free(NULL) is a no-op
2 lines changed: 0 ins; 1 del; 1 mod; 6702 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/spa_config.c

patch tsoome-feedback
2 lines changed: 0 ins; 1 del; 1 mod; 542 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/zfs_ioctl.c

6659 nvlist_free(NULL) is a no-op
2 lines changed: 0 ins; 1 del; 1 mod; 6283 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/comstar/lu/stmf_sbd/sbd.c

patch tsoome-feedback
2 lines changed: 0 ins; 1 del; 1 mod; 3717 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/comstar/port/iscsit/iscsit.c

6659 nvlist_free(NULL) is a no-op
2 lines changed: 0 ins; 1 del; 1 mod; 3429 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/comstar/port/pppt/alua_ic_if.c

6659 nvlist_free(NULL) is a no-op
6 lines changed: 0 ins; 3 del; 3 mod; 2287 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/comstar/stmf/stmf.c

6659 nvlist_free(NULL) is a no-op
4 lines changed: 0 ins; 2 del; 2 mod; 7989 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/devfm.c

patch tsoome-feedback
6 lines changed: 0 ins; 3 del; 3 mod; 427 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/ipp/ippctl.c

patch tsoome-feedback
2 lines changed: 0 ins; 1 del; 1 mod; 1829 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/contract.c

6659 nvlist_free(NULL) is a no-op
4 lines changed: 0 ins; 2 del; 2 mod; 2683 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/damap.c

6659 nvlist_free(NULL) is a no-op
6 lines changed: 0 ins; 3 del; 3 mod; 1725 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/devid_cache.c

6659 nvlist_free(NULL) is a no-op
2 lines changed: 0 ins; 1 del; 1 mod; 1169 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/evchannels.c

6659 nvlist_free(NULL) is a no-op
4 lines changed: 0 ins; 2 del; 2 mod; 2342 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/retire_store.c

patch cleanup
6659 nvlist_free(NULL) is a no-op
4 lines changed: 0 ins; 3 del; 1 mod; 453 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/sunmdi.c

6659 nvlist_free(NULL) is a no-op
2 lines changed: 0 ins; 1 del; 1 mod; 9743 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/sunndi.c

patch tsoome-feedback
2 lines changed: 0 ins; 1 del; 1 mod; 2590 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/zone.c

patch tsoome-feedback
6659 nvlist_free(NULL) is a no-op
10 lines changed: 0 ins; 5 del; 5 mod; 7164 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/xen/os/xvdi.c

patch tsoome-feedback
2 lines changed: 0 ins; 1 del; 1 mod; 2414 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/io/intel_nb5000/intel_nbdrv.c

6659 nvlist_free(NULL) is a no-op
2 lines changed: 0 ins; 1 del; 1 mod; 555 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/io/intel_nhm/dimm_topo.c

6659 nvlist_free(NULL) is a no-op
2 lines changed: 0 ins; 1 del; 1 mod; 266 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/io/pci/pci_boot.c

6659 nvlist_free(NULL) is a no-op
2 lines changed: 0 ins; 1 del; 1 mod; 3400 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.