Code Review for 3317-dis-cross-target-full

Prepared by:Jeff (jeffpc) on 2014-Aug-01 16:03 -0400 EDT
Workspace:/home/jeffpc/illumos/cross-dis (at f6145993456d)
Compare against: master (at 63e911b6fce0)
Summary of changes: 1027 lines changed: 547 ins; 326 del; 154 mod; 7222 unchg
Patch of changes: 3317-dis-cross-target-full.patch
Printable review: 3317-dis-cross-target-full.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dis/dis_main.c 

3317 dis(1) should support cross-target disassembly
29 lines changed: 19 ins; 5 del; 5 mod; 710 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dis/dis_target.c 

3317 dis(1) should support cross-target disassembly
2 lines changed: 0 ins; 2 del; 0 mod; 976 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dis/dis_target.h 

3317 dis(1) should support cross-target disassembly
2 lines changed: 0 ins; 2 del; 0 mod; 92 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/Makefile.com 

patch fix-lint
3317 dis(1) should support cross-target disassembly
53 lines changed: 20 ins; 17 del; 16 mod; 104 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/Makefile.targ 

3317 dis(1) should support cross-target disassembly
5 lines changed: 0 ins; 5 del; 0 mod; 92 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/amd64/Makefile 

3317 dis(1) should support cross-target disassembly
3 lines changed: 2 ins; 1 del; 0 mod; 36 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libdisasm/common/dis_i386.c 

patch fix-lint
3317 dis(1) should support cross-target disassembly
256 lines changed: 256 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/common/dis_sparc.c (renamed and modified from usr/src/lib/libdisasm/sparc/dis_sparc.c) 

patch fix-lint
3317 dis(1) should support cross-target disassembly
96 lines changed: 39 ins; 23 del; 34 mod; 286 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/common/dis_sparc.h (renamed and modified from usr/src/lib/libdisasm/sparc/dis_sparc.h) 

3317 dis(1) should support cross-target disassembly
13 lines changed: 0 ins; 8 del; 5 mod; 96 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/common/dis_sparc_fmt.c (renamed and modified from usr/src/lib/libdisasm/sparc/dis_sparc_fmt.c) 

patch fix-lint
3317 dis(1) should support cross-target disassembly
102 lines changed: 20 ins; 2 del; 80 mod; 2672 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/common/dis_sparc_fmt.h (renamed and modified from usr/src/lib/libdisasm/sparc/dis_sparc_fmt.h) 

3317 dis(1) should support cross-target disassembly
2 lines changed: 0 ins; 2 del; 0 mod; 122 unchg

------ ------ ------ ------ ------ Old New Patch Raw usr/src/lib/libdisasm/common/dis_sparc_instr.c (renamed from usr/src/lib/libdisasm/sparc/instr.c) 

3317 dis(1) should support cross-target disassembly
0 lines changed: 0 ins; 0 del; 0 mod; 1701 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/common/libdisasm.c 

patch fix-lint
3317 dis(1) should support cross-target disassembly
156 lines changed: 154 ins; 2 del; 0 mod; 90 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/common/libdisasm.h 

3317 dis(1) should support cross-target disassembly
18 lines changed: 7 ins; 0 del; 11 mod; 70 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/common/libdisasm_impl.h 

patch fix-lint
3317 dis(1) should support cross-target disassembly
28 lines changed: 27 ins; 0 del; 1 mod; 44 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/common/linktest_stand.c 

patch fix-lint
4 lines changed: 0 ins; 2 del; 2 mod; 40 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/common/mapfile-vers 

3317 dis(1) should support cross-target disassembly
1 line changed: 1 ins; 0 del; 0 mod; 56 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdisasm/i386/Makefile 

3317 dis(1) should support cross-target disassembly
3 lines changed: 2 ins; 1 del; 0 mod; 35 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/lib/libdisasm/i386/dis_i386.c (deleted) 

3317 dis(1) should support cross-target disassembly
254 lines changed: 0 ins; 254 del; 0 mod; 0 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.