Code Review for wip-cpu

Prepared by:Jeff (jeffpc) on 2014-Jan-03 22:12 -0500 EST
Workspace:/home/jeffpc/illumos/cpu-pause-func (at bba27fcebdc2)
Compare against: master (at b7dfa236c6cf)
Summary of changes: 449 lines changed: 83 ins; 258 del; 108 mod; 45672 unchg
Patch of changes: wip-cpu.patch
Printable review: wip-cpu.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/cpr/cpr_main.c

patch cpu-pause-func-deglobalize
17 lines changed: 0 ins; 15 del; 2 mod; 1377 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/disp/cmt.c

patch cpu-pause-func-deglobalize
3 lines changed: 0 ins; 0 del; 3 mod; 1962 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/disp/cpupart.c

patch cpu-pause-func-deglobalize
3 lines changed: 0 ins; 0 del; 3 mod; 1228 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/disp/disp.c

patch setfrontbackdq
patch cpu-pause-func-deglobalize
284 lines changed: 73 ins; 169 del; 42 mod; 2490 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/cpu.c

patch cpu-pause-func-deglobalize
19 lines changed: 3 ins; 2 del; 14 mod; 3434 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/cpu_event.c

patch cpu-pause-func-deglobalize
2 lines changed: 0 ins; 0 del; 2 mod; 1154 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/cpu_pm.c

patch cpu-pause-func-deglobalize
2 lines changed: 0 ins; 0 del; 2 mod; 789 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/lgrp.c

patch cpu-pause-func-deglobalize
3 lines changed: 0 ins; 0 del; 3 mod; 4438 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/lgrp_topo.c

patch cpu-pause-func-deglobalize
1 line changed: 0 ins; 0 del; 1 mod; 1591 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/mem_config.c

patch cpu-pause-func-deglobalize
1 line changed: 0 ins; 0 del; 1 mod; 3316 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/cpuvar.h

patch cpu-pause-func-deglobalize
1 line changed: 0 ins; 0 del; 1 mod; 838 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/i86hvm/io/xpv/xpv_support.c

patch cpu-pause-func-deglobalize
1 line changed: 0 ins; 0 del; 1 mod; 815 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/io/dr/dr_quiesce.c

patch cpu-pause-func-deglobalize
1 line changed: 0 ins; 0 del; 1 mod; 1044 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/io/pcplusmp/apic.c

patch apic-simplify
patch remove-apic_cr8pri
patch spacing-fix
patch apic-task-reg-write-dup
66 lines changed: 0 ins; 56 del; 10 mod; 1336 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/io/pcplusmp/apic_regops.c

patch use-x2apic-feature
patch apic-simplify
patch apic-task-reg-write-dup
9 lines changed: 0 ins; 6 del; 3 mod; 397 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/io/ppm/acpisleep.c

patch cpu-pause-func-deglobalize
2 lines changed: 0 ins; 2 del; 0 mod; 185 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/os/cpr_impl.c

patch cpu-pause-func-deglobalize
1 line changed: 0 ins; 0 del; 1 mod; 1137 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/os/cpuid.c

patch x2apic-x86fset
patch remove-unused-vars
10 lines changed: 5 ins; 4 del; 1 mod; 4759 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/os/machdep.c

patch cpu-pause-func-deglobalize
1 line changed: 0 ins; 0 del; 1 mod; 1441 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/os/mp_pc.c

patch cpu-pause-func-deglobalize
1 line changed: 0 ins; 1 del; 0 mod; 659 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/os/x_call.c

patch cpu-pause-func-deglobalize
1 line changed: 0 ins; 0 del; 1 mod; 705 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86xpv/os/mp_xen.c

patch cpu-pause-func-deglobalize
1 line changed: 0 ins; 0 del; 1 mod; 1058 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/sys/x86_archext.h

patch x2apic-x86fset
patch remove-unused-vars
8 lines changed: 2 ins; 3 del; 3 mod; 855 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4/os/mp_states.c

patch cpu-pause-func-deglobalize
1 line changed: 0 ins; 0 del; 1 mod; 331 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4/os/prom_subr.c

patch cpu-pause-func-deglobalize
2 lines changed: 0 ins; 0 del; 2 mod; 589 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/io/mem_cache.c

patch cpu-pause-func-deglobalize
1 line changed: 0 ins; 0 del; 1 mod; 968 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/ngdr/io/dr_quiesce.c

patch cpu-pause-func-deglobalize
1 line changed: 0 ins; 0 del; 1 mod; 1106 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/os/cpr_impl.c

patch cpu-pause-func-deglobalize
1 line changed: 0 ins; 0 del; 1 mod; 2028 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/serengeti/io/sbdp_quiesce.c

patch cpu-pause-func-deglobalize
1 line changed: 0 ins; 0 del; 1 mod; 888 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4v/os/mpo.c

patch cpu-pause-func-deglobalize
1 line changed: 0 ins; 0 del; 1 mod; 2039 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4v/os/suspend.c

patch cpu-pause-func-deglobalize
3 lines changed: 0 ins; 0 del; 3 mod; 715 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.