Code Review for 5255-uts-shouldnt-open-code-ISP2

Prepared by: (jeffpc) on 2014-Oct-23 10:42 -0400 EDT
Workspace:/home/jeffpc/illumos/spatch (at 8fe754f65365)
Compare against: HEAD^ (at d8eb8859bd8b)
Summary of changes: 133 lines changed: 24 ins; 23 del; 86 mod; 113773 unchg
Patch of changes: 5255-uts-shouldnt-open-code-ISP2.patch
Printable review: 5255-uts-shouldnt-open-code-ISP2.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/dtrace/dtrace.c

5255 uts shouldn't open-code ISP2
1 line changed: 0 ins; 0 del; 1 mod; 16913 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/dtrace/fasttrap.c

5255 uts shouldn't open-code ISP2
3 lines changed: 0 ins; 0 del; 3 mod; 2383 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/dcfs/dc_vnops.c

5255 uts shouldn't open-code ISP2
2 lines changed: 0 ins; 1 del; 1 mod; 1125 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/zio.c

5255 uts shouldn't open-code ISP2
2 lines changed: 1 ins; 0 del; 1 mod; 3249 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/ilb/ilb.c

5255 uts shouldn't open-code ISP2
2 lines changed: 1 ins; 0 del; 1 mod; 2155 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/ilb/ilb_conn.c

5255 uts shouldn't open-code ISP2
3 lines changed: 1 ins; 0 del; 2 mod; 1529 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/sctp/sctp_hash.c

5255 uts shouldn't open-code ISP2
2 lines changed: 1 ins; 0 del; 1 mod; 898 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/udp/udp.c

5255 uts shouldn't open-code ISP2
2 lines changed: 1 ins; 0 del; 1 mod; 6460 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/1394/t1394.c

5255 uts shouldn't open-code ISP2
4 lines changed: 1 ins; 2 del; 1 mod; 3776 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/arn/arn_main.c

5255 uts shouldn't open-code ISP2
7 lines changed: 1 ins; 4 del; 2 mod; 3549 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/comstar/lu/stmf_sbd/sbd.c

5255 uts shouldn't open-code ISP2
2 lines changed: 1 ins; 0 del; 1 mod; 3715 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/comstar/port/fct/discovery.c

5255 uts shouldn't open-code ISP2
2 lines changed: 1 ins; 0 del; 1 mod; 2845 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/drm/drmP.h

5255 uts shouldn't open-code ISP2
4 lines changed: 1 ins; 3 del; 0 mod; 1101 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/ib/adapters/hermon/hermon_cfg.c

5255 uts shouldn't open-code ISP2
2 lines changed: 1 ins; 0 del; 1 mod; 532 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/ib/adapters/hermon/hermon_qp.c

5255 uts shouldn't open-code ISP2
13 lines changed: 0 ins; 2 del; 11 mod; 2919 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/ib/adapters/hermon/hermon_qpmod.c

5255 uts shouldn't open-code ISP2
3 lines changed: 1 ins; 0 del; 2 mod; 3436 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/ib/adapters/hermon/hermon_rsrc.c

5255 uts shouldn't open-code ISP2
2 lines changed: 1 ins; 0 del; 1 mod; 2684 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/ib/adapters/hermon/hermon_srq.c

5255 uts shouldn't open-code ISP2
4 lines changed: 1 ins; 0 del; 3 mod; 993 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/ib/adapters/tavor/tavor_cfg.c

5255 uts shouldn't open-code ISP2
2 lines changed: 1 ins; 0 del; 1 mod; 814 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/ib/adapters/tavor/tavor_qp.c

5255 uts shouldn't open-code ISP2
8 lines changed: 0 ins; 0 del; 8 mod; 2068 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/ib/adapters/tavor/tavor_qpmod.c

5255 uts shouldn't open-code ISP2
3 lines changed: 1 ins; 0 del; 2 mod; 3499 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/ib/adapters/tavor/tavor_rsrc.c

5255 uts shouldn't open-code ISP2
2 lines changed: 1 ins; 0 del; 1 mod; 2907 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/ib/adapters/tavor/tavor_srq.c

5255 uts shouldn't open-code ISP2
4 lines changed: 1 ins; 0 del; 3 mod; 1122 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/ib/clients/rds/rdssubr.c

5255 uts shouldn't open-code ISP2
2 lines changed: 1 ins; 0 del; 1 mod; 308 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/myri10ge/drv/myri10ge.c

5255 uts shouldn't open-code ISP2
2 lines changed: 0 ins; 0 del; 2 mod; 6176 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/ntxn/unm_gem.c

5255 uts shouldn't open-code ISP2
6 lines changed: 0 ins; 3 del; 3 mod; 1506 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/krtld/kobj.c

5255 uts shouldn't open-code ISP2
1 line changed: 0 ins; 0 del; 1 mod; 4667 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/group.c

5255 uts shouldn't open-code ISP2
3 lines changed: 1 ins; 1 del; 1 mod; 452 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/kmem.c

5255 uts shouldn't open-code ISP2
1 line changed: 0 ins; 0 del; 1 mod; 5586 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/vmem.c

5255 uts shouldn't open-code ISP2
5 lines changed: 0 ins; 1 del; 4 mod; 1784 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/vm/seg_kmem.c

5255 uts shouldn't open-code ISP2
6 lines changed: 0 ins; 2 del; 4 mod; 1639 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/vm/seg_map.c

5255 uts shouldn't open-code ISP2
1 line changed: 0 ins; 0 del; 1 mod; 2353 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/vm/vpm.c

5255 uts shouldn't open-code ISP2
1 line changed: 0 ins; 0 del; 1 mod; 1179 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/io/acpi/drmach_acpi/drmach_acpi.c

5255 uts shouldn't open-code ISP2
1 line changed: 0 ins; 0 del; 1 mod; 2926 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/io/pci/pci_tools.c

5255 uts shouldn't open-code ISP2
2 lines changed: 1 ins; 0 del; 1 mod; 1200 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/io/rootnex.c

5255 uts shouldn't open-code ISP2
2 lines changed: 0 ins; 0 del; 2 mod; 5170 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/os/ddi_impl.c

5255 uts shouldn't open-code ISP2
4 lines changed: 0 ins; 1 del; 3 mod; 2920 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/io/drm/i915_gem_tiling.c

5255 uts shouldn't open-code ISP2
2 lines changed: 1 ins; 0 del; 1 mod; 388 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4/io/px/px_debug.c

5255 uts shouldn't open-code ISP2
4 lines changed: 1 ins; 2 del; 1 mod; 289 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4/os/ddi_impl.c

5255 uts shouldn't open-code ISP2
5 lines changed: 0 ins; 1 del; 4 mod; 1936 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4v/io/ds_pri.c

5255 uts shouldn't open-code ISP2
1 line changed: 0 ins; 0 del; 1 mod; 937 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4v/os/fillsysinfo.c

5255 uts shouldn't open-code ISP2
2 lines changed: 0 ins; 0 del; 2 mod; 1432 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4v/os/intrq.c

5255 uts shouldn't open-code ISP2
3 lines changed: 1 ins; 0 del; 2 mod; 253 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.